Drop nostr_last_checked table, remove references
#647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thesimplekid
approved these changes
Mar 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#645 removed
nostr_last_checkedreferences from the mint storage, but the table schema and data remain.This PR drops the table from the various storage backends:
cdk-sqlite: added a migration to drop the tablecdk-redb: due to a typo, theNOSTR_LAST_CHECKEDkey was pointing to thekeyset_countertable, so nonostr_last_checkedwas ever created. Here, this PR simply removes redb references toNOSTR_LAST_CHECKED.cdk-rexie: bump the DB version and do not add theNOSTR_LAST_CHECKEDobject store.Checklist
just final-checkbefore committing